Small optimization reducing repeated int.ToString calls in completion#82765
Merged
ToddGrun merged 2 commits intodotnet:mainfrom Mar 17, 2026
Merged
Conversation
SymbolCompletionItem.CreateWorker can be called thousands of times for each completion list, and in the scenarios I've tested, it passes in the same contextPosition for each call. We need this context position as a string to store in a properties collection, so previously the code always ToString'ed the position. This PR creates a simple single item cache that is used to commonly avoid this allocation. Not a huge win, but it's 0.2% of total allocations in the trace I'm looking at.
Contributor
Author
|
@dotnet/roslyn-ide ptal |
jasonmalinowski
approved these changes
Mar 17, 2026
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
It's a bit hard to tell whether this ContextPosition is really needed much in the first place -- I can't entirely tell if this is the location of the symbol, or just being used for figuring out quick info later. But the change here is simple enough.
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SymbolCompletionItem.CreateWorker can be called thousands of times for each completion list, and in the scenarios I've tested, it passes in the same contextPosition for each call. We need this context position as a string to store in a properties collection, so previously the code always ToString'ed the position. This PR creates a simple single item cache that is used to commonly avoid this allocation.
Not a huge win, but it's 0.2% of total allocations in the trace I'm looking at.